[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/2] qapi: Introduce NVMe disk bus type
From: |
Markus Armbruster |
Subject: |
Re: [PATCH 1/2] qapi: Introduce NVMe disk bus type |
Date: |
Wed, 02 Mar 2022 10:35:54 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
zhenwei pi <pizhenwei@bytedance.com> writes:
> Assigning a NVMe disk by VFIO or emulating a NVMe controller by QEMU,
> a NVMe disk get exposed in guest side. Support NVMe disk bus type for
> QAPI.
>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qga/qapi-schema.json | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> index 94e4aacdcc..1b5ea4c5f8 100644
> --- a/qga/qapi-schema.json
> +++ b/qga/qapi-schema.json
> @@ -827,13 +827,14 @@
> # @mmc: Win multimedia card (MMC) bus type
> # @virtual: Win virtual bus type
> # @file-backed-virtual: Win file-backed bus type
> +# @nvme: NVMe disks
> #
> # Since: 2.2; 'Unknown' and all entries below since 2.4
> ##
> { 'enum': 'GuestDiskBusType',
> 'data': [ 'ide', 'fdc', 'scsi', 'virtio', 'xen', 'usb', 'uml', 'sata',
> 'sd', 'unknown', 'ieee1394', 'ssa', 'fibre', 'raid', 'iscsi',
> - 'sas', 'mmc', 'virtual', 'file-backed-virtual' ] }
> + 'sas', 'mmc', 'virtual', 'file-backed-virtual', 'nvme' ] }
>
>
> ##
Please change the title to something like
qga: Introduce NVMe disk bus type
I'd squash the two patches together.