Re: [PATCH v2 00/25] migration: Postcopy Preemption

[Peter Xu]

On Wed, Mar 02, 2022 at 12:14:30PM +0000, Dr. David Alan Gilbert wrote:
> * Peter Xu (peterx@redhat.com) wrote:
> > This is v2 of postcopy preempt series.  It can also be found here:
> > 
> >   https://github.com/xzpeter/qemu/tree/postcopy-preempt
> > 
> > RFC: 
> > https://lore.kernel.org/qemu-devel/20220119080929.39485-1-peterx@redhat.com
> > V1:  
> > https://lore.kernel.org/qemu-devel/20220216062809.57179-1-peterx@redhat.com
> 
> I've queued some of this:
> 
> tests: Pass in MigrateStart** into test_migrate_start()
> migration: Add migration_incoming_transport_cleanup()
> migration: postcopy_pause_fault_thread() never fails
> migration: Enlarge postcopy recovery to capture !-EIO too
> migration: Move static var in ram_block_from_stream() into global
> migration: Add postcopy_thread_create()
> migration: Dump ramblock and offset too when non-same-page detected
> migration: Introduce postcopy channels on dest node
> migration: Tracepoint change in postcopy-run bottom half
> migration: Finer grained tracepoints for POSTCOPY_LISTEN
> migration: Dump sub-cmd name in loadvm_process_command tp

They all look pretty safe to merge, thanks!

We could even consider to postpone merging of below two patches:

  migration: Move static var in ram_block_from_stream() into global
  migration: Introduce postcopy channels on dest node

Because fundamentally if we want to only merge postcopy preempt as a whole,
then these two patches do not bring anything beneficial to the existing
code but should be accounted for part of the impl of the preempt mode.

Said that, I think it's still fine to merge them too, as long as we're very
sure we'll finally merge preempt code when tls side of thing is ready.

-- 
Peter Xu