Re: [PATCH 5/7] target/nios2: Split mmu_write

[Peter Maydell]

On Sun, 27 Feb 2022 at 18:27, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Create three separate functions for the three separate registers.
> Avoid extra dispatch through op_helper.c.
> Dispatch to the correct function in translation.
> Clean up the ifdefs in wrctl.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
>  target/nios2/helper.h    |   4 +-
>  target/nios2/mmu.c       | 180 +++++++++++++++++++--------------------
>  target/nios2/op_helper.c |   5 --
>  target/nios2/translate.c |  26 +++---
>  4 files changed, 104 insertions(+), 111 deletions(-)

You forgot to delete the prototype for mmu_write() in mmu.h.
Otherwise
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

thanks
-- PMM