|
From: | Liav Albani |
Subject: | Re: [PATCH v4 2/3] hw/acpi: add indication for i8042 in IA-PC boot flags of the FADT table |
Date: | Wed, 2 Mar 2022 17:45:58 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 |
So, in which route should I go with this? I could add a reference to the ACPI spec, but can write and explain more if you want me to.but I feel quoting spec and including table name is a good idea actually, but pls quote verbatim:I don't do that and don't ask it from others. The reason being that pointing where to look in spec and having verbatim copy of field name is sufficient for looking it up and QEMU does not endup with half of spec copied in (+unintentional mistakes). (As reviewer I will check if whatever written in patch actually matches spec anyways) That's why I typically use 'spec ver, verbatim field name[, chapter/table name]' policy. The later optional part is usually used for pointing to values description.Ok but here the field name was not listed verbatim, and table name is missing. It is actually 8042 and table name is Fixed ACPI Description Table Boot Architecture Flags.
[Prev in Thread] | Current Thread | [Next in Thread] |