[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: propagating vmgenid outward and upward
From: |
Jason A. Donenfeld |
Subject: |
Re: propagating vmgenid outward and upward |
Date: |
Wed, 2 Mar 2022 17:32:07 +0100 |
Hi Michael,
On Wed, Mar 02, 2022 at 11:22:46AM -0500, Michael S. Tsirkin wrote:
> > Because that 16 byte read of vmgenid is not atomic. Let's say you read
> > the first 8 bytes, and then the VM is forked.
>
> But at this point when VM was forked plaintext key and nonce are all in
> buffer, and you previously indicated a fork at this point is harmless.
> You wrote "If it changes _after_ that point of check ... it doesn't
> matter:"
Ahhh, fair point. I think you're right.
Alright, so all we're talking about here is an ordinary 16-byte read,
and 16 bytes of storage per keypair, and a 16-byte comparison.
Still seems much worse than just having a single word...
Jason
- Re: propagating vmgenid outward and upward, (continued)
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Jason A. Donenfeld, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Jason A. Donenfeld, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Jason A. Donenfeld, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Jason A. Donenfeld, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward,
Jason A. Donenfeld <=
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/03
- Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/02
Re: propagating vmgenid outward and upward, Michael S. Tsirkin, 2022/03/01
Re: propagating vmgenid outward and upward, Greg KH, 2022/03/01
Re: propagating vmgenid outward and upward, Jason A. Donenfeld, 2022/03/02