Re: [PATCH v6 07/19] vfio-user: define vfio-user-server object

[Stefan Hajnoczi]

On Mon, Feb 28, 2022 at 07:14:21PM +0000, Jag Raman wrote:
> > On Feb 21, 2022, at 10:37 AM, Stefan Hajnoczi <stefanha@redhat.com> wrote:
> > On Thu, Feb 17, 2022 at 02:48:54AM -0500, Jagannathan Raman wrote:
> >> +struct VfuObjectClass {
> >> +    ObjectClass parent_class;
> >> +
> >> +    unsigned int nr_devs;
> >> +
> >> +    /*
> >> +     * Can be set to shutdown automatically when all server object
> >> +     * instances are destroyed
> >> +     */
> >> +    bool auto_shutdown;
> > 
> > This field is introduced but it is hardcoded to true. Is there a way to
> > set it to false?
> 
> We could add a property to ’TYPE_REMOTE_MACHINE’ which indicates if
> it would run as a server/daemon.

Yes.

An alternative is to add a per-instance property to --object
x-vfio-user-server. In practice there is not much benefit since users
are unlikely to mix auto-shutdown instances with non-auto-shutdown
instances, but the code might be a little simpler and cleaner.

Stefan

signature.asc
Description: PGP signature