[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ
From: |
Eugenio Pérez |
Subject: |
[PATCH v3 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ |
Date: |
Wed, 2 Mar 2022 21:30:09 +0100 |
This is needed to achieve migration, so the destination can restore its
index.
Setting base as last used idx, so destination will see as available all
the entries that the device did not use, including the in-flight
processing ones.
This is ok for networking, but other kinds of devices might have
problems with these retransmissions.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 17 +++++++++++++++++
1 file changed, 17 insertions(+)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index a386a83eb1..151622fb34 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1143,8 +1143,25 @@ static int vhost_vdpa_set_vring_base(struct vhost_dev
*dev,
static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
struct vhost_vring_state *ring)
{
+ struct vhost_vdpa *v = dev->opaque;
int ret;
+ if (v->shadow_vqs_enabled) {
+ VhostShadowVirtqueue *svq = g_ptr_array_index(v->shadow_vqs,
+ ring->index);
+
+ /*
+ * Setting base as last used idx, so destination will see as available
+ * all the entries that the device did not use, including the in-flight
+ * processing ones.
+ *
+ * TODO: This is ok for networking, but other kinds of devices might
+ * have problems with these retransmissions.
+ */
+ ring->num = svq->last_used_idx;
+ return 0;
+ }
+
ret = vhost_vdpa_call(dev, VHOST_GET_VRING_BASE, ring);
trace_vhost_vdpa_get_vring_base(dev, ring->index, ring->num);
return ret;
--
2.27.0
- [PATCH v3 01/14] vhost: Add VhostShadowVirtqueue, (continued)
- [PATCH v3 01/14] vhost: Add VhostShadowVirtqueue, Eugenio Pérez, 2022/03/02
- [PATCH v3 02/14] vhost: Add Shadow VirtQueue kick forwarding capabilities, Eugenio Pérez, 2022/03/02
- [PATCH v3 03/14] vhost: Add Shadow VirtQueue call forwarding capabilities, Eugenio Pérez, 2022/03/02
- [PATCH v3 04/14] vhost: Add vhost_svq_valid_features to shadow vq, Eugenio Pérez, 2022/03/02
- [PATCH v3 05/14] virtio: Add vhost_svq_get_vring_addr, Eugenio Pérez, 2022/03/02
- [PATCH v3 06/14] vdpa: adapt vhost_ops callbacks to svq, Eugenio Pérez, 2022/03/02
- [PATCH v3 07/14] vhost: Shadow virtqueue buffers forwarding, Eugenio Pérez, 2022/03/02
- [PATCH v3 08/14] util: Add iova_tree_alloc_map, Eugenio Pérez, 2022/03/02
- [PATCH v3 09/14] vhost: Add VhostIOVATree, Eugenio Pérez, 2022/03/02
- [PATCH v3 10/14] vdpa: Add custom IOTLB translations to SVQ, Eugenio Pérez, 2022/03/02
- [PATCH v3 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ,
Eugenio Pérez <=
- [PATCH v3 12/14] vdpa: Never set log_base addr if SVQ is enabled, Eugenio Pérez, 2022/03/02
- [PATCH v3 13/14] vdpa: Expose VHOST_F_LOG_ALL on SVQ, Eugenio Pérez, 2022/03/02
- [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Pérez, 2022/03/02
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Markus Armbruster, 2022/03/03
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Perez Martin, 2022/03/03
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Markus Armbruster, 2022/03/03
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Perez Martin, 2022/03/03
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Markus Armbruster, 2022/03/04
- Re: [PATCH v3 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Perez Martin, 2022/03/04