Re: [PATCH v2 2/4] target/nios2: Exteral Interrupt Controller (EIC)

[Peter Maydell]

On Thu, 3 Mar 2022 at 09:54, Amir Gonnen <amir.gonnen@neuroblade.ai> wrote:
>
> > This looks wrong.  Of course, so does nios2_cpu_set_irq, from which you've 
> > cribbed this.
>
> > For our purposes, I think simply re-using env->regs[CR_IPENDING] as the 
> > external hw
> > request word is the right thing to do.   But we need to update RDCTL to 
> > compute the
> > correct value from CR_IPENDING & CR_IENABLE, and update WRCTL to ignore 
> > writes.
>
> Since you've already fixed that on " target/nios2: Rewrite interrupt 
> handling" patchset, I guess I'll need to rebase on it once it's merged.
> Until then for my next version I plan to just keep that with a "TODO" comment.

If you like you could rebase on those patches already; then when you
send your next version of the series include in the cover letter
the lines

Based-on: 20220227182125.21809-1-richard.henderson@linaro.org
("target/nios2: Rewrite interrupt handling")

The first of those tells the automated tooling like patchew.org that
it should apply the referenced patchseries first before trying to
apply and test your series; the second is for humans to read.

That might save you having to respin twice.

thanks
-- PMM