qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v4 11/14] softmmu/memory: add memory_region_try_add_subregion


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v4 11/14] softmmu/memory: add memory_region_try_add_subregion function
Date: Thu, 3 Mar 2022 14:32:44 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 23/2/22 10:12, Damien Hedde wrote:
Hi Philippe,

I suppose it is ok if I change your mail in the reviewed by ?

No, the email is fine (git tools should take care of using the
correct email via the .mailmap entry, see commit 90f285fd83).

Thanks,
Damien

On 2/23/22 10:07, Damien Hedde wrote:
It allows adding a subregion to a memory region with error handling.
Like memory_region_add_subregion_overlap(), it handles priority as
well. Apart from the error handling, the behavior is the same. It
can be used to do the simple memory_region_add_subregion() (with no
overlap) by setting the priority parameter to 0.

This commit is a preparation to further use of this function in the
context of qapi command which needs error handling support.

Signed-off-by: Damien Hedde <damien.hedde@greensocs.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
---
  include/exec/memory.h | 22 ++++++++++++++++++++++
  softmmu/memory.c      | 23 +++++++++++++++--------
  2 files changed, 37 insertions(+), 8 deletions(-)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]