[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH V7 02/29] migration: fix populate_vfio_info
From: |
Steven Sistare |
Subject: |
Re: [PATCH V7 02/29] migration: fix populate_vfio_info |
Date: |
Thu, 3 Mar 2022 11:38:02 -0500 |
User-agent: |
Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 |
On 3/3/2022 11:21 AM, Peter Maydell wrote:
> On Thu, 3 Mar 2022 at 15:55, Steven Sistare <steven.sistare@oracle.com> wrote:
>>
>> On 2/24/2022 1:42 PM, Peter Maydell wrote:
>>> ...it also seems to be making a no-change-of-behaviour rewrite
>>> of the rest of the file. Is there a reason I'm missing for doing
>>> that ?
>
>> I'll change the commit message to explain:
>>
>> Include CONFIG_DEVICES so that populate_vfio_info is instantiated for
>> CONFIG_VFIO, and refactor so only one ifdef is needed when new functions
>> are added in a later patch.
>>
>> The later patch is "vfio-pci: cpr part 1 (fd and dma)"
>
> I'd prefer it if you split this patch into two patches; these two changes
> aren't related.
>
> thanks
> -- PMM
Will do - Steve