[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 12/14] vdpa: Never set log_base addr if SVQ is enabled
From: |
Eugenio Pérez |
Subject: |
[PATCH v4 12/14] vdpa: Never set log_base addr if SVQ is enabled |
Date: |
Thu, 3 Mar 2022 19:51:45 +0100 |
Setting the log address would make the device start reporting invalid
dirty memory because the SVQ vrings are located in qemu's memory.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 69a4bfd0d4..5470566ce2 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1092,7 +1092,8 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev,
bool started)
static int vhost_vdpa_set_log_base(struct vhost_dev *dev, uint64_t base,
struct vhost_log *log)
{
- if (vhost_vdpa_one_time_request(dev)) {
+ struct vhost_vdpa *v = dev->opaque;
+ if (v->shadow_vqs_enabled || vhost_vdpa_one_time_request(dev)) {
return 0;
}
--
2.27.0
- [PATCH v4 04/14] vhost: Add vhost_svq_valid_features to shadow vq, (continued)
- [PATCH v4 04/14] vhost: Add vhost_svq_valid_features to shadow vq, Eugenio Pérez, 2022/03/03
- [PATCH v4 05/14] virtio: Add vhost_svq_get_vring_addr, Eugenio Pérez, 2022/03/03
- [PATCH v4 06/14] vdpa: adapt vhost_ops callbacks to svq, Eugenio Pérez, 2022/03/03
- [PATCH v4 07/14] vhost: Shadow virtqueue buffers forwarding, Eugenio Pérez, 2022/03/03
- [PATCH v4 08/14] util: Add iova_tree_alloc_map, Eugenio Pérez, 2022/03/03
- [PATCH v4 09/14] vhost: Add VhostIOVATree, Eugenio Pérez, 2022/03/03
- [PATCH v4 10/14] vdpa: Add custom IOTLB translations to SVQ, Eugenio Pérez, 2022/03/03
- [PATCH v4 11/14] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ, Eugenio Pérez, 2022/03/03
- [PATCH v4 12/14] vdpa: Never set log_base addr if SVQ is enabled,
Eugenio Pérez <=
- [PATCH v4 13/14] vdpa: Expose VHOST_F_LOG_ALL on SVQ, Eugenio Pérez, 2022/03/03
- [PATCH v4 14/14] vdpa: Add x-svq to NetdevVhostVDPAOptions, Eugenio Pérez, 2022/03/03