Re: [PATCH v2 08/12] mos6522: add "info via" HMP command for debugging

[Laurent Vivier]

Le 24/02/2022 à 12:59, Mark Cave-Ayland a écrit :
> This displays detailed information about the device registers and timers to aid
> debugging problems with timers and interrupts.
>
> Currently the QAPI generators for HumanReadableText don't work correctly if
> used in qapi/target-misc.json when a non-specified target is built, so for
> now manually add a hmp_info_via() wrapper until direct support for per-device
> HMP/QMP commands is implemented.
>
> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> ---
>   hmp-commands-info.hx         |  15 +++++
>   hw/misc/mos6522.c            | 103 +++++++++++++++++++++++++++++++++++
>   include/hw/misc/mos6522.h    |   2 +
>   include/monitor/hmp-target.h |   1 +
>   4 files changed, 121 insertions(+)

Reviewed-by: Laurent Vivier <laurent@vivier.eu>