[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 6/8] chardev: add API to block use of the stdio implementa
From: |
Eric Blake |
Subject: |
Re: [PATCH v2 6/8] chardev: add API to block use of the stdio implementation |
Date: |
Fri, 4 Mar 2022 16:03:36 -0600 |
User-agent: |
NeoMutt/20211029-383-c6e293 |
On Fri, Mar 04, 2022 at 06:56:18PM +0000, Daniel P. Berrangé wrote:
> When daemonizing QEMU it is not possible to use the stdio chardev
> backend because the file descriptors are connected to /dev/null.
> Currently the chardev checks for this scenario directly, but to
> decouple it from the system emulator daemonizing code, we reverse
> the relationship. Now the system emulator calls a helper to
> explicitly disable use of the stdio backend.
>
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
> chardev/char-stdio.c | 12 ++++++++++--
> include/chardev/char-stdio.h | 29 +++++++++++++++++++++++++++++
> softmmu/vl.c | 2 ++
> 3 files changed, 41 insertions(+), 2 deletions(-)
> create mode 100644 include/chardev/char-stdio.h
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
- [PATCH v2 0/8] softmmu: move and refactor -runas, -chroot and -daemonize, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 1/8] softmmu: remove deprecated --enable-fips option, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 2/8] os-posix: refactor code handling the -runas argument, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 3/8] os-posix: refactor code handling the -chroot argument, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 4/8] util: remove use of is_daemonized flag from logging code, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 5/8] softmmu: refactor use of is_daemonized() method, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 6/8] chardev: add API to block use of the stdio implementation, Daniel P . Berrangé, 2022/03/04
- Re: [PATCH v2 6/8] chardev: add API to block use of the stdio implementation,
Eric Blake <=
- [PATCH v2 7/8] softmmu: move parsing of -runas, -chroot and -daemonize code, Daniel P . Berrangé, 2022/03/04
- [PATCH v2 8/8] softmmu: remove is_daemonized() method, Daniel P . Berrangé, 2022/03/04