|
From: | Philippe Mathieu-Daudé |
Subject: | Re: [PATCH v2 5/9] meson.build: Don't misdetect posix_memalign() on Windows |
Date: | Sat, 5 Mar 2022 01:48:57 +0100 |
User-agent: | Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 |
On 4/3/22 12:21, Peter Maydell wrote:
Currently we incorrectly think that posix_memalign() exists on Windows. This is because of a combination of: * the msys2/mingw toolchain/libc claim to have a __builtin_posix_memalign when there isn't a builtin of that name * meson will assume that if you have a __builtin_foo that counts for has_function('foo') Specifying a specific include file via prefix: causes meson to not treat builtins as sufficient and actually look for the function itself; see this meson pull request which added that as the official way to get the right answer: https://github.com/mesonbuild/meson/pull/1150
Interesting, TIL. Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Currently this misdectection doesn't cause problems because we only use CONFIG_POSIX_MEMALIGN in oslib-posix.c; however that will change in a following commit. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Message-id: 20220226180723.1706285-6-peter.maydell@linaro.org --- meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
[Prev in Thread] | Current Thread | [Next in Thread] |