qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 3/3] nsis installer: Fix mouse-over descriptions for emulator


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 3/3] nsis installer: Fix mouse-over descriptions for emulators
Date: Sat, 5 Mar 2022 12:19:26 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 5/3/22 11:57, Peter Maydell wrote:
We use the nsis.py script to write out an installer script Section
for each emulator executable, so the exact set of Sections depends on
which executables were built.  However the part of qemu.nsi which
specifies mouse-over descriptions for each Section still has a
hard-coded and very outdated list (with just i386 and alpha).  This
causes two problems.  Firstly, if you build the installer for a
configuration where you didn't build the i386 binaries you get
warnings like this:
   warning 6000: unknown variable/constant "{Section_i386}" detected, ignoring 
(macro:_==:1)
   warning 6000: unknown variable/constant "{Section_i386w}" detected, ignoring 
(macro:_==:1)
(this happens in our gitlab CI jobs, for instance).
Secondly, most of the emulators in the generated installer don't have
any mouseover text.

Make nsis.py generate a second output file which has the necessary
MUI_DESCRIPTION_TEXT lines for each Section it creates, so we can
include that at the right point in qemu.nsi to set the mouse-over
text.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I opted to put the logic into the Python script, which I think
many QEMU contributors understand, rather than investigating
whether NSIS installer script magic might for instance allow
us to write out only one file rather than two, since I think
very few of us understand the NSIS installer...

Very much appreciated.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

---
  qemu.nsi        |  5 +----
  scripts/nsis.py | 13 ++++++++++++-
  2 files changed, 13 insertions(+), 5 deletions(-)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]