Re: [PATCH 07/18] migration: fix use of TLS PSK credentials with a UNIX socket

[Daniel P . Berrangé]

On Mon, Mar 07, 2022 at 03:08:53PM +0800, Peter Xu wrote:
> On Wed, Mar 02, 2022 at 05:49:21PM +0000, Daniel P. Berrangé wrote:
> > The migration TLS code has a check mandating that a hostname be
> > available when starting a TLS session. This is expected when using
> > x509 credentials, but is bogus for PSK and anonymous credentials
> > as neither involve hostname validation.
> > 
> > The TLS crdentials object gained suitable error reporting in the
> > case of TLS with x509 credentials, so there is no longer any need
> > for the migration code to do its own (incorrect) validation.
> > 
> > Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> 
> Do we need a Fixes tag for this?

It is fuzzy as we never really intended for UNIX sockets to use TLS
originally.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|