[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/9] util/log.c: add LOG_UNSUPP type
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH 1/9] util/log.c: add LOG_UNSUPP type |
Date: |
Mon, 7 Mar 2022 16:15:45 -0300 |
The existing log type 'LOG_UNIMP' is being used as a way to indicate
that a certain feature is not implemented, and to indicate that a
feature is unsupported. Most of the time both cases are similar, until
you want to debug a guest that is running a not so common OS (e.g. AIX
guest in a pseries machine).
The result is that you can be overwhelmed with lots of '-d unimp'
messages of hypercalls and have to do code searches to verify whether a
specific hypercall is something we never considered adding versus
something that we decided to not support. Note that while the first case
is eligible for further investigation the second is already settled. It
would be helpful to able to distinguish between both.
This patch adds a new log type called LOG_UNSUPP to represent this
subset of features that we are aware of and we decided to not support.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
include/qemu/log.h | 3 ++-
util/log.c | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/qemu/log.h b/include/qemu/log.h
index 9b80660207..884a81495b 100644
--- a/include/qemu/log.h
+++ b/include/qemu/log.h
@@ -14,7 +14,7 @@ typedef struct QemuLogFile {
extern QemuLogFile *qemu_logfile;
-/*
+/*
* The new API:
*
*/
@@ -64,6 +64,7 @@ static inline bool qemu_log_separate(void)
#define CPU_LOG_PLUGIN (1 << 18)
/* LOG_STRACE is used for user-mode strace logging. */
#define LOG_STRACE (1 << 19)
+#define LOG_UNSUPP (1 << 20)
/* Lock output for a series of related logs. Since this is not needed
* for a single qemu_log / qemu_log_mask / qemu_log_mask_and_addr, we
diff --git a/util/log.c b/util/log.c
index 2ee1500bee..3e19859ab3 100644
--- a/util/log.c
+++ b/util/log.c
@@ -334,6 +334,8 @@ const QEMULogItem qemu_log_items[] = {
#endif
{ LOG_STRACE, "strace",
"log every user-mode syscall, its input, and its result" },
+ { LOG_UNSUPP, "unsupp",
+ "log unsupported functionality" },
{ 0, NULL, NULL },
};
--
2.35.1
- [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp, Daniel Henrique Barboza, 2022/03/07
- [PATCH 1/9] util/log.c: add LOG_UNSUPP type,
Daniel Henrique Barboza <=
- [PATCH 2/9] hw/ppc/spapr_hcall.c: log h_clean_slb() as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 3/9] hw/ppc/spapr_hcall.c: log h_invalidate_pid() as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 4/9] hw/ppc/spapr_hcall.c: log h_copy_tofrom_guest() as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 5/9] hw/ppc/spapr_hcall.c: log H_GET_EM_PARMS as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 6/9] hw/ppc/spapr_hcall.c: log H_BEST_ENERGY as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 7/9] hw/ppc/spapr_hcall.c: log H_QUERY_VAS_CAPABILITIES as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 8/9] hw/ppc/spapr_hcall.c: log H_GET_PPP as unsupported, Daniel Henrique Barboza, 2022/03/07
- [PATCH 9/9] hw/ppc/spapr_hcall.c: log H_VIOCTL as unsupported, Daniel Henrique Barboza, 2022/03/07
- Re: [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp, Philippe Mathieu-Daudé, 2022/03/07
- Re: [PATCH 0/9] add LOG_UNSUPP log type + mark hcalls as unsupp, Peter Maydell, 2022/03/07