[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 09/33] target/nios2: Split control registers away from gen
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v4 09/33] target/nios2: Split control registers away from general registers |
|
Date: |
Tue, 8 Mar 2022 10:04:15 +0000 |
On Tue, 8 Mar 2022 at 07:20, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Place the control registers into their own array, env->ctrl[].
>
> Use an anonymous union and struct to give the entries in the
> array distinct names, so that one may write env->foo instead
> of env->ctrl[CR_FOO].
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Not 100% sold on the union, but
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v4 02/33] target/nios2: Stop generating code if gen_check_supervisor fails, (continued)
- [PATCH v4 02/33] target/nios2: Stop generating code if gen_check_supervisor fails, Richard Henderson, 2022/03/08
- [PATCH v4 03/33] target/nios2: Add NUM_GP_REGS and NUM_CP_REGS, Richard Henderson, 2022/03/08
- [PATCH v4 07/33] linux-user/nios2: Trim target_pc_regs to sp and pc, Richard Henderson, 2022/03/08
- [PATCH v4 08/33] target/nios2: Remove cpu_interrupts_enabled, Richard Henderson, 2022/03/08
- [PATCH v4 09/33] target/nios2: Split control registers away from general registers, Richard Henderson, 2022/03/08
- Re: [PATCH v4 09/33] target/nios2: Split control registers away from general registers,
Peter Maydell <=
- [PATCH v4 05/33] target/nios2: Split out helper for eret instruction, Richard Henderson, 2022/03/08
- [PATCH v4 04/33] target/nios2: Split PC out of env->regs[], Richard Henderson, 2022/03/08
- [PATCH v4 12/33] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields, Richard Henderson, 2022/03/08
- [PATCH v4 17/33] target/nios2: Prevent writes to read-only or reserved control fields, Richard Henderson, 2022/03/08