qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

qemu-softmmu -cpu help broken


From: Max Filippov
Subject: qemu-softmmu -cpu help broken
Date: Thu, 10 Mar 2022 03:10:55 -0800

Hello,

I've noticed that the command
 qemu-system-xtensa -cpu help
no longer prints anything. Apparently because cpu_list is no longer defined
in list_cpus inside softmmu/cpus.c

Bisection points to the following commit:
e0220bb5b200 ("softmmu: Build target-agnostic objects once")

Reverting the change for the cpus.c fixes it for me:

diff --git a/softmmu/meson.build b/softmmu/meson.build
index 8138248661a2..adede5e604db 100644
--- a/softmmu/meson.build
+++ b/softmmu/meson.build
@@ -1,5 +1,6 @@
specific_ss.add(when: 'CONFIG_SOFTMMU', if_true: [files(
  'arch_init.c',
+  'cpus.c',
  'ioport.c',
  'memory.c',
  'physmem.c',
@@ -13,7 +14,6 @@ specific_ss.add(when: ['CONFIG_SOFTMMU',
'CONFIG_TCG'], if_true: [files(
softmmu_ss.add(files(
  'balloon.c',
  'bootdevice.c',
-  'cpus.c',
  'cpu-throttle.c',
  'cpu-timers.c',
  'datadir.c',

I can send a proper patch if this is the right fix, please
let me know.

-- 
Thanks.
-- Max



reply via email to

[Prev in Thread] Current Thread [Next in Thread]