[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v5 08/48] linux-user/nios2: Only initialize SP and PC in targ
From: |
Peter Maydell |
Subject: |
Re: [PATCH v5 08/48] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs |
Date: |
Thu, 10 Mar 2022 12:18:49 +0000 |
On Thu, 10 Mar 2022 at 11:27, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Drop the set of estatus in init_thread; it was clearly intended
> to be setting the value of CR_STATUS for the application, but we
> never actually performed that copy. However, the proper value is
> set in nios2_cpu_reset so we don't need to do anything here.
>
> We only initialize SP and EA in init_thread, there's no value in
> copying other uninitialized data into ENV.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH v5 00/48] target/nios2: Shadow register set, EIC and VIC, Richard Henderson, 2022/03/10
- [PATCH v5 02/48] target/nios2: Stop generating code if gen_check_supervisor fails, Richard Henderson, 2022/03/10
- [PATCH v5 01/48] target/nios2: Check supervisor on eret, Richard Henderson, 2022/03/10
- [PATCH v5 04/48] target/nios2: Split PC out of env->regs[], Richard Henderson, 2022/03/10
- [PATCH v5 03/48] target/nios2: Add NUM_GP_REGS and NUM_CP_REGS, Richard Henderson, 2022/03/10
- [PATCH v5 05/48] target/nios2: Split out helper for eret instruction, Richard Henderson, 2022/03/10
- [PATCH v5 06/48] target/nios2: Fix BRET instruction, Richard Henderson, 2022/03/10
- [PATCH v5 07/48] target/nios2: Do not create TCGv for control registers, Richard Henderson, 2022/03/10
- [PATCH v5 08/48] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs, Richard Henderson, 2022/03/10
- Re: [PATCH v5 08/48] linux-user/nios2: Only initialize SP and PC in target_cpu_copy_regs,
Peter Maydell <=
- [PATCH v5 09/48] target/nios2: Remove cpu_interrupts_enabled, Richard Henderson, 2022/03/10
- [PATCH v5 13/48] target/nios2: Use hw/registerfields.h for CR_STATUS fields, Richard Henderson, 2022/03/10
- [PATCH v5 11/48] target/nios2: Do not zero the general registers on reset, Richard Henderson, 2022/03/10
- [PATCH v5 10/48] target/nios2: Split control registers away from general registers, Richard Henderson, 2022/03/10
- [PATCH v5 12/48] target/nios2: Clean up nios2_cpu_dump_state, Richard Henderson, 2022/03/10
- [PATCH v5 15/48] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, Richard Henderson, 2022/03/10
- [PATCH v5 14/48] target/nios2: Use hw/registerfields.h for CR_EXCEPTION fields, Richard Henderson, 2022/03/10