[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 8/8] migration: Use multifd before we check for the zero page
From: |
Juan Quintela |
Subject: |
[PATCH v5 8/8] migration: Use multifd before we check for the zero page |
Date: |
Thu, 10 Mar 2022 16:34:54 +0100 |
So we use multifd to transmit zero pages.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
- Check zero_page property before using new code (Dave)
---
migration/ram.c | 32 +++++++++++++++++++++++++++++++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/migration/ram.c b/migration/ram.c
index 141817d6a7..628b5554ba 100644
--- a/migration/ram.c
+++ b/migration/ram.c
@@ -2175,6 +2175,32 @@ static int ram_save_target_page_legacy(RAMState *rs,
PageSearchStatus *pss)
return ram_save_page(rs, pss);
}
+/**
+ * ram_save_target_page_multifd: save one target page
+ *
+ * Returns the number of pages written
+ *
+ * @rs: current RAM state
+ * @pss: data about the page we want to send
+ */
+static int ram_save_target_page_multifd(RAMState *rs, PageSearchStatus *pss)
+{
+ RAMBlock *block = pss->block;
+ ram_addr_t offset = ((ram_addr_t)pss->page) << TARGET_PAGE_BITS;
+ int res;
+
+ if (!migration_in_postcopy()) {
+ return ram_save_multifd_page(rs, block, offset);
+ }
+
+ res = save_zero_page(rs, block, offset);
+ if (res > 0) {
+ return res;
+ }
+
+ return ram_save_page(rs, pss);
+}
+
/**
* ram_save_host_page: save a whole host page
*
@@ -2938,7 +2964,11 @@ static int ram_save_setup(QEMUFile *f, void *opaque)
ram_control_before_iterate(f, RAM_CONTROL_SETUP);
ram_control_after_iterate(f, RAM_CONTROL_SETUP);
- (*rsp)->ram_save_target_page = ram_save_target_page_legacy;
+ if (migrate_use_multifd() && migrate_use_multifd_zero_page()) {
+ (*rsp)->ram_save_target_page = ram_save_target_page_multifd;
+ } else {
+ (*rsp)->ram_save_target_page = ram_save_target_page_legacy;
+ }
multifd_send_sync_main(f);
qemu_put_be64(f, RAM_SAVE_FLAG_EOS);
qemu_fflush(f);
--
2.34.1
- [PATCH v5 0/8] Migration: Transmit and detect zero pages in the multifd threads, Juan Quintela, 2022/03/10
- [PATCH v5 1/8] migration: Export ram_transferred_ram(), Juan Quintela, 2022/03/10
- [PATCH v5 2/8] multifd: Count the number of sent bytes correctly, Juan Quintela, 2022/03/10
- [PATCH v5 4/8] multifd: Add property to enable/disable zero_page, Juan Quintela, 2022/03/10
- [PATCH v5 5/8] migration: Export ram_release_page(), Juan Quintela, 2022/03/10
- [PATCH v5 3/8] migration: Make ram_save_target_page() a pointer, Juan Quintela, 2022/03/10
- [PATCH v5 6/8] multifd: Support for zero pages transmission, Juan Quintela, 2022/03/10
- [PATCH v5 8/8] migration: Use multifd before we check for the zero page,
Juan Quintela <=
- [PATCH v5 7/8] multifd: Zero pages transmission, Juan Quintela, 2022/03/10