[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] s390x/tcg: Fix BRCL with a large negative offset
|
From: |
David Hildenbrand |
|
Subject: |
Re: [PATCH 2/3] s390x/tcg: Fix BRCL with a large negative offset |
|
Date: |
Fri, 11 Mar 2022 19:55:39 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2 |
On 11.03.22 19:49, Ilya Leoshkevich wrote:
> When RI2 is 0x80000000, qemu enters an infinite loop instead of jumping
> backwards. Fix by adding a missing cast, like in in2_ri2().
>
> Fixes: 7233f2ed1717 ("target-s390: Convert BRANCH ON CONDITION")
> Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
> ---
> target/s390x/tcg/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c
> index 41c8696185..5acfc0ff9b 100644
> --- a/target/s390x/tcg/translate.c
> +++ b/target/s390x/tcg/translate.c
> @@ -1201,7 +1201,7 @@ static DisasJumpType help_branch(DisasContext *s,
> DisasCompare *c,
> bool is_imm, int imm, TCGv_i64 cdest)
> {
> DisasJumpType ret;
> - uint64_t dest = s->base.pc_next + 2 * imm;
> + uint64_t dest = s->base.pc_next + (int64_t)imm * 2;
> TCGLabel *lab;
>
> /* Take care of the special cases first. */
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb