[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL v2 01/12] Hexagon (target/hexagon) fix bug in circular addressing
From: |
Taylor Simpson |
Subject: |
[PULL v2 01/12] Hexagon (target/hexagon) fix bug in circular addressing |
Date: |
Sat, 12 Mar 2022 12:13:08 -0800 |
From: Michael Lambert <mlambert@quicinc.com>
Versions V3 and earlier should treat the "K_const" and "length" values
as unsigned.
Modified circ_test_v3() in tests/tcg/hexagon/circ.c to reproduce the bug
Signed-off-by: Michael Lambert <mlambert@quicinc.com>
Signed-off-by: Taylor Simpson <tsimpson@quicinc.com>
Message-Id: <20220210021556.9217-2-tsimpson@quicinc.com>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hexagon/op_helper.c | 6 +++---
tests/tcg/hexagon/circ.c | 5 +++--
2 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/target/hexagon/op_helper.c b/target/hexagon/op_helper.c
index 057baf9a48..47bd51e0ca 100644
--- a/target/hexagon/op_helper.c
+++ b/target/hexagon/op_helper.c
@@ -1,5 +1,5 @@
/*
- * Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights
Reserved.
+ * Copyright(c) 2019-2022 Qualcomm Innovation Center, Inc. All Rights
Reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -304,8 +304,8 @@ void HELPER(debug_commit_end)(CPUHexagonState *env, int
has_st0, int has_st1)
int32_t HELPER(fcircadd)(int32_t RxV, int32_t offset, int32_t M, int32_t CS)
{
- int32_t K_const = sextract32(M, 24, 4);
- int32_t length = sextract32(M, 0, 17);
+ uint32_t K_const = extract32(M, 24, 4);
+ uint32_t length = extract32(M, 0, 17);
uint32_t new_ptr = RxV + offset;
uint32_t start_addr;
uint32_t end_addr;
diff --git a/tests/tcg/hexagon/circ.c b/tests/tcg/hexagon/circ.c
index 67a1aa3054..354416eb6d 100644
--- a/tests/tcg/hexagon/circ.c
+++ b/tests/tcg/hexagon/circ.c
@@ -1,5 +1,5 @@
/*
- * Copyright(c) 2019-2021 Qualcomm Innovation Center, Inc. All Rights
Reserved.
+ * Copyright(c) 2019-2022 Qualcomm Innovation Center, Inc. All Rights
Reserved.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -415,7 +415,8 @@ static void circ_test_v3(void)
{
int *p = wbuf;
int size = 15;
- int K = 4; /* 64 bytes */
+ /* set high bit in K to test unsigned extract in fcirc */
+ int K = 8; /* 1024 bytes */
int element;
int i;
--
2.17.1
- [PULL v2 00/12] Hexagon (target/hexagon) queue, Taylor Simpson, 2022/03/12
- [PULL v2 01/12] Hexagon (target/hexagon) fix bug in circular addressing,
Taylor Simpson <=
- [PULL v2 10/12] Hexagon (target/hexagon) fix bug in conv_df2uw_chop, Taylor Simpson, 2022/03/12
- [PULL v2 09/12] Hexagon (tests/tcg/hexagon) fix inline asm in preg_alias.c, Taylor Simpson, 2022/03/12
- [PULL v2 12/12] target/hexagon: remove unused variable, Taylor Simpson, 2022/03/12
- [PULL v2 07/12] Hexagon (tests/tcg/hexagon) add floating point instructions to usr.c, Taylor Simpson, 2022/03/12
- [PULL v2 03/12] Hexagon (target/hexagon) properly set FPINVF bit in sfcmp.uo and dfcmp.uo, Taylor Simpson, 2022/03/12
- [PULL v2 04/12] Hexagon (target/hexagon) properly handle denorm in arch_sf_recip_common, Taylor Simpson, 2022/03/12
- [PULL v2 08/12] Hexagon (tests/tcg/hexagon) update overflow test, Taylor Simpson, 2022/03/12
- [PULL v2 11/12] Hexagon (target/hexagon) assignment to c4 should wait until packet commit, Taylor Simpson, 2022/03/12
- [PULL v2 02/12] Hexagon HVX (target/hexagon) fix bug in HVX saturate instructions, Taylor Simpson, 2022/03/12
- [PULL v2 06/12] Hexagon (tests/tcg/hexagon) test instructions that might set bits in USR, Taylor Simpson, 2022/03/12