qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-7.0 v2] softmmu: List CPU types again


From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-7.0 v2] softmmu: List CPU types again
Date: Mon, 14 Mar 2022 14:59:52 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1

On 10/3/22 16:16, Thomas Huth wrote:
On 10/03/2022 15.07, Philippe Mathieu-Daudé wrote:
From: Philippe Mathieu-Daudé <f4bug@amsat.org>

Commit e0220bb5b2 made cpus.c target-agnostic but didn't notice
the cpu_list() function is only defined in target-specific code
in "cpu.h". Move list_cpus() declaration to "exec/cpu-common.h"
because this function is not softmmu-specific and can also be
used by user-mode, along with moving its implementation to cpu.c,
which is compiled per target.

Fixes: e0220bb5b2 ("softmmu: Build target-agnostic objects once")
Reported-by: Max Filippov <jcmvbkbc@gmail.com>
Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
---
  cpu.c                     | 9 +++++++++
  include/exec/cpu-common.h | 2 ++
  include/sysemu/cpus.h     | 2 --
  softmmu/cpus.c            | 8 --------
  4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/cpu.c b/cpu.c
index d564886149..d50845f713 100644
--- a/cpu.c
+++ b/cpu.c
@@ -35,6 +35,7 @@
  #include "sysemu/tcg.h"
  #include "sysemu/kvm.h"
  #include "sysemu/replay.h"
+#include "exec/cpu-all.h"

Why not cpu-common.h?

Copy/paste mistake I presume.

Reviewed-by: Thomas Huth <thuth@redhat.com>

Thanks!




reply via email to

[Prev in Thread] Current Thread [Next in Thread]