Re: [PATCH v2 1/6] block: Support passing NULL ops to blk_set_dev_ops()

[Stefan Hajnoczi]

On Tue, Feb 15, 2022 at 06:59:38PM +0800, Xie Yongji wrote:
> This supports passing NULL ops to blk_set_dev_ops()
> so that we can remove stale ops in some cases.
> 
> Signed-off-by: Xie Yongji <xieyongji@bytedance.com>
> ---
>  block/block-backend.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/block/block-backend.c b/block/block-backend.c
> index 4ff6b4d785..08dd0a3093 100644
> --- a/block/block-backend.c
> +++ b/block/block-backend.c
> @@ -1015,7 +1015,7 @@ void blk_set_dev_ops(BlockBackend *blk, const 
> BlockDevOps *ops,
>      blk->dev_opaque = opaque;
>  
>      /* Are we currently quiesced? Should we enforce this right now? */
> -    if (blk->quiesce_counter && ops->drained_begin) {
> +    if (blk->quiesce_counter && ops && ops->drained_begin) {
>          ops->drained_begin(opaque);
>      }
>  }

John: You added this code in f4d9cc88ee6. Does blk_set_dev_ops() need to
call ->drained_end() when ops is set to NULL?

Stefan

signature.asc
Description: PGP signature