[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL V3 14/15] vdpa: Never set log_base addr if SVQ is enabled
From: |
Jason Wang |
Subject: |
[PULL V3 14/15] vdpa: Never set log_base addr if SVQ is enabled |
Date: |
Tue, 15 Mar 2022 14:14:19 +0800 |
From: Eugenio Pérez <eperezma@redhat.com>
Setting the log address would make the device start reporting invalid
dirty memory because the SVQ vrings are located in qemu's memory.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
hw/virtio/vhost-vdpa.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 93dbe10..89d59f8 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1090,7 +1090,8 @@ static int vhost_vdpa_dev_start(struct vhost_dev *dev,
bool started)
static int vhost_vdpa_set_log_base(struct vhost_dev *dev, uint64_t base,
struct vhost_log *log)
{
- if (vhost_vdpa_one_time_request(dev)) {
+ struct vhost_vdpa *v = dev->opaque;
+ if (v->shadow_vqs_enabled || vhost_vdpa_one_time_request(dev)) {
return 0;
}
--
2.7.4
- [PULL V3 04/15] vhost: Add Shadow VirtQueue call forwarding capabilities, (continued)
- [PULL V3 04/15] vhost: Add Shadow VirtQueue call forwarding capabilities, Jason Wang, 2022/03/15
- [PULL V3 05/15] vhost: Add vhost_svq_valid_features to shadow vq, Jason Wang, 2022/03/15
- [PULL V3 06/15] virtio: Add vhost_svq_get_vring_addr, Jason Wang, 2022/03/15
- [PULL V3 07/15] vdpa: adapt vhost_ops callbacks to svq, Jason Wang, 2022/03/15
- [PULL V3 08/15] vhost: Shadow virtqueue buffers forwarding, Jason Wang, 2022/03/15
- [PULL V3 09/15] util: Add iova_tree_alloc_map, Jason Wang, 2022/03/15
- [PULL V3 10/15] util: add iova_tree_find_iova, Jason Wang, 2022/03/15
- [PULL V3 12/15] vdpa: Add custom IOTLB translations to SVQ, Jason Wang, 2022/03/15
- [PULL V3 11/15] vhost: Add VhostIOVATree, Jason Wang, 2022/03/15
- [PULL V3 13/15] vdpa: Adapt vhost_vdpa_get_vring_base to SVQ, Jason Wang, 2022/03/15
- [PULL V3 14/15] vdpa: Never set log_base addr if SVQ is enabled,
Jason Wang <=
- [PULL V3 15/15] vdpa: Expose VHOST_F_LOG_ALL on SVQ, Jason Wang, 2022/03/15
- Re: [PULL V3 00/15] Net patches, Peter Maydell, 2022/03/15