Re: [PATCH v2 2/2] Added parameter to take screenshot with screendump as PNG.

[Markus Armbruster]

Kshitij Suri <kshitij.suri@nutanix.com> writes:

> On 11/03/22 5:50 pm, Markus Armbruster wrote:
>> Kshitij Suri <kshitij.suri@nutanix.com> writes:
>>
>>> Currently screendump only supports PPM format, which is un-compressed and 
>>> not
>>> standard. Added a "format" parameter to qemu monitor screendump capabilites
>>> to support PNG image capture using libpng. The param was added in QAPI 
>>> schema
>>> of screendump present in ui.json along with png_save() function which 
>>> converts
>>> pixman_image to PNG. HMP command equivalent was also modified to support the
>>> feature.
>>>
>>> Example usage:
>>> { "execute": "screendump", "arguments": { "filename": "/tmp/image",
>>> "format":"png" } }
>>>
>>> Resolves: 
>>> https://urldefense.proofpoint.com/v2/url?u=https-3A__gitlab.com_qemu-2Dproject_qemu_-2D_issues_718&d=DwIBAg&c=s883GpUCOChKOHiocYtGcg&r=utjv19Ej9Fb0TB7_DX0o3faQ-OAm2ypPniPyqVSoj_w&m=SxmcA4FlCCy9O9eUaDUiSY37bauF6iJbDRVL--VUyTG5Vze_GFjmJuxgwAVYRjad&s=OIKnm9xXYjeat7TyIJ_-z9EvG2XYXMULNbHe0Bjzyjo&e=
>>>
>>> Signed-off-by: Kshitij Suri <kshitij.suri@nutanix.com>

[...]

>>> diff --git a/qapi/ui.json b/qapi/ui.json
>>> index 9354f4c467..6aa0dd7c1b 100644
>>> --- a/qapi/ui.json
>>> +++ b/qapi/ui.json

[...]

>>>   ##
>>>   # @screendump:
>>>   #
>>> -# Write a PPM of the VGA screen to a file.
>>> +# Write a screenshot of the VGA screen to a file.
>>
>> Is "VGA screen" accurate?  Or does this work for other displays, too?
>
> The patch didn't modify any display changes and VGA screen was
> previously supported display type.

Let me rephrase my question: was "VGA screen" accurate before your
patch?

[...]