Re: [PATCH v2 2/2] target/riscv: Allow software access to MIP SEIP

[Richard Henderson]

On 3/15/22 18:59, Alistair Francis wrote:
> +    if (mask & MIP_SEIP) {
> +        env->software_seip = new_val & MIP_SEIP;
> +    }
> +    new_val |= env->external_seip << IRQ_S_EXT;

You can move the second statement inside the if as well, since you don't need bits in 
new_val set that are not in mask.

Also might be clearer as

        env->external_seip * MIP_SEIP

rather than the shift, to make it clear we're talking about the same bit.  The compiler 
will reduce the multiplication.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~