[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] tests/avocado: starts PhoneServer upfront
From: |
Cleber Rosa |
Subject: |
Re: [PATCH v2] tests/avocado: starts PhoneServer upfront |
Date: |
Wed, 16 Mar 2022 07:49:24 -0400 |
User-agent: |
mu4e 1.6.6; emacs 27.2 |
Beraldo Leal <bleal@redhat.com> writes:
> Race conditions can happen with the current code, because the port that
> was available might not be anymore by the time the server is started.
>
> By setting the port to 0, PhoneServer it will use the OS default
> behavior to get a free port, then we save this information so we can
> later configure the guest.
>
> Suggested-by: Daniel P. Berrangé <berrange@redhat.com>
> Signed-off-by: Beraldo Leal <bleal@redhat.com>
> ---
> tests/avocado/avocado_qemu/__init__.py | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>