[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 26/27] tests: replace free_all() usage with g_auto
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH 26/27] tests: replace free_all() usage with g_auto |
|
Date: |
Wed, 16 Mar 2022 14:00:24 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) |
Marc-André Lureau <marcandre.lureau@redhat.com> writes:
> Hi
>
> On Wed, Mar 16, 2022 at 4:33 PM Markus Armbruster <armbru@redhat.com> wrote:
>>
>> marcandre.lureau@redhat.com writes:
>>
>> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
>> >
>> > Use more idiomatic glib/auto-style code.
>> >
>> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
>>
>> This is a bit of an improvement, but by its own, it's a rather weak
>> justification for the previous patch. Do you have more uses of
>> g_autoptr in the pipe?
>
>
> There are a lot of similar g_auto cleanups to be done in qemu code
> base for QObject types. But I started with those tests, because they
> use a pretty unorthodox free_all pattern and that shouldn't be
> repeated.
Would it make sense to add this the list of bite-sized tasks?