[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] 9pfs: fix inode sequencing in 'synth' driver
|
From: |
Christian Schoenebeck |
|
Subject: |
Re: [PATCH] 9pfs: fix inode sequencing in 'synth' driver |
|
Date: |
Wed, 16 Mar 2022 19:16:24 +0100 |
On Mittwoch, 16. März 2022 12:10:43 CET Greg Kurz wrote:
> On Mon, 14 Mar 2022 19:58:11 +0100
>
> Christian Schoenebeck <qemu_oss@crudebyte.com> wrote:
> > The 'synth' driver's root node and the 'synth' driver's first
> > subdirectory node falsely share the same inode number (zero), which
> > makes it impossible for 9p clients (i.e. 9p test cases) to distinguish
> > root node and first subdirectory from each other by comparing their QIDs
> > (which are derived by 9p server from driver's inode numbers).
> >
> > Fix this issue by using prefix-increment instead of postfix-increment
> > operator while generating new inode numbers for subdirectories and files.
> >
> > Link: https://lore.kernel.org/qemu-devel/3859307.hTDP4D0zbi@silver/
> > Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> > ---
>
> Good catch !
>
> Reviewed-by: Greg Kurz <groug@kaod.org>
Queued on 9p.next:
https://github.com/cschoenebeck/qemu/commits/9p.next
Thanks!
Best regards,
Christian Schoenebeck