Re: [PATCH 04/27] meson: add util dependency for oslib-posix on freebsd

[Marc-André Lureau]

Hi

On Wed, Mar 16, 2022 at 1:52 PM <marcandre.lureau@redhat.com> wrote:
>
> From: Marc-André Lureau <marcandre.lureau@redhat.com>
>
> kinfo_getproc() requires it.

This is required for correctness and for the next patch, which moves
qemu-openpty and its "util" dependency away from util_ss.

Please review

>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
>  util/meson.build | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/util/meson.build b/util/meson.build
> index f6ee74ad0c85..bb0b010662d7 100644
> --- a/util/meson.build
> +++ b/util/meson.build
> @@ -11,7 +11,11 @@ util_ss.add(when: linux_io_uring, if_true: 
> files('fdmon-io_uring.c'))
>  util_ss.add(when: 'CONFIG_POSIX', if_true: files('compatfd.c'))
>  util_ss.add(when: 'CONFIG_POSIX', if_true: files('event_notifier-posix.c'))
>  util_ss.add(when: 'CONFIG_POSIX', if_true: files('mmap-alloc.c'))
> -util_ss.add(when: 'CONFIG_POSIX', if_true: files('oslib-posix.c'))
> +freebsd_dep = []
> +if targetos == 'freebsd'
> +  freebsd_dep = util
> +endif
> +util_ss.add(when: 'CONFIG_POSIX', if_true: [files('oslib-posix.c'), 
> freebsd_dep])
>  util_ss.add(when: 'CONFIG_POSIX', if_true: [files('qemu-openpty.c'), util])
>  util_ss.add(when: 'CONFIG_POSIX', if_true: files('qemu-thread-posix.c'))
>  util_ss.add(when: 'CONFIG_POSIX', if_true: files('memfd.c'))
> --
> 2.35.1.273.ge6ebfd0e8cbb
>