qemu-devel
[Top][All Lists]
Advanced
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 2/3] hw/display: Allow vga_common_init() to return errors

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH v2 2/3] hw/display: Allow vga_common_init() to return errors
Date: Thu, 17 Mar 2022 12:19:32 +0100
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 
On 17/3/22 09:30, Thomas Huth wrote:

The vga_common_init() function currently cannot report errors to its
caller. But in the following patch, we'd need this possibility, so
let's change it to take an "Error **" as parameter for this.


Thanks for updating to return a boolean.

Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>


Signed-off-by: Thomas Huth <thuth@redhat.com>
---
  hw/display/vga_int.h        |  2 +-
  hw/display/ati.c            |  4 +++-
  hw/display/cirrus_vga.c     |  4 +++-
  hw/display/cirrus_vga_isa.c |  4 +++-
  hw/display/qxl.c            |  6 +++++-
  hw/display/vga-isa.c        |  5 ++++-
  hw/display/vga-mmio.c       |  5 ++++-
  hw/display/vga-pci.c        |  8 ++++++--
  hw/display/vga.c            | 11 +++++++++--
  hw/display/virtio-vga.c     |  4 +++-
  hw/display/vmware_vga.c     |  2 +-
  11 files changed, 42 insertions(+), 13 deletions(-)
reply via email to
[Prev in Thread] Current Thread [Next in Thread]