qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 11/14] iotests: replace qemu_img_log('create', ...) calls


From: Hanna Reitz
Subject: Re: [PATCH 11/14] iotests: replace qemu_img_log('create', ...) calls
Date: Thu, 17 Mar 2022 15:44:26 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

On 09.03.22 04:54, John Snow wrote:
qemu_img_log() calls into qemu_img_pipe(), which always removes output
for 'create' commands on success anyway. Replace all of these calls to
the simpler qemu_img_create(...) which doesn't log, but raises a
detailed exception object on failure instead.

Blank lines are removed from output files where appropriate.

Signed-off-by: John Snow <jsnow@redhat.com>
---
  tests/qemu-iotests/255     |  8 ++++----
  tests/qemu-iotests/255.out |  4 ----
  tests/qemu-iotests/274     | 17 ++++++++---------
  tests/qemu-iotests/274.out | 29 -----------------------------
  tests/qemu-iotests/280     |  2 +-
  tests/qemu-iotests/280.out |  1 -
  6 files changed, 13 insertions(+), 48 deletions(-)

Reviewed-by: Hanna Reitz <hreitz@redhat.com>




reply via email to

[Prev in Thread] Current Thread [Next in Thread]