[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.1 v6 21/51] target/nios2: Clean up nios2_cpu_do_interru
From: |
Peter Maydell |
Subject: |
Re: [PATCH for-7.1 v6 21/51] target/nios2: Clean up nios2_cpu_do_interrupt |
Date: |
Thu, 17 Mar 2022 15:24:24 +0000 |
On Thu, 17 Mar 2022 at 05:46, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Split out do_exception and do_iic_irq to handle bulk of the interrupt and
> exception processing. Parameterize the changes required to cpu state.
>
> The status.EH bit, which protects some data against double-faults,
> is only present with the MMU. Several exception cases did not check
> for status.EH being set, as required.
>
> The status.IH bit, which had been set by EXCP_IRQ, is exclusive to
> the external interrupt controller, which we do not yet implement.
> The internal interrupt controller, when the MMU is also present,
> sets the status.EH bit.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH for-7.1 v6 15/51] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, (continued)
- [PATCH for-7.1 v6 15/51] target/nios2: Use hw/registerfields.h for CR_TLBADDR fields, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 16/51] target/nios2: Use hw/registerfields.h for CR_TLBACC fields, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 17/51] target/nios2: Rename CR_TLBMISC_WR to CR_TLBMISC_WE, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 18/51] target/nios2: Use hw/registerfields.h for CR_TLBMISC fields, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 20/51] target/nios2: Create EXCP_SEMIHOST for semi-hosting, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 19/51] target/nios2: Move R_FOO and CR_BAR into enumerations, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 22/51] target/nios2: Hoist CPU_LOG_INT logging, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 21/51] target/nios2: Clean up nios2_cpu_do_interrupt, Richard Henderson, 2022/03/17
- Re: [PATCH for-7.1 v6 21/51] target/nios2: Clean up nios2_cpu_do_interrupt,
Peter Maydell <=
- [PATCH for-7.1 v6 23/51] target/nios2: Handle EXCP_UNALIGN and EXCP_UALIGND, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 25/51] target/nios2: Clean up handling of tlbmisc in do_exception, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 29/51] target/nios2: Remove CPU_INTERRUPT_NMI, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 24/51] target/nios2: Cleanup set of CR_EXCEPTION for do_interrupt, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 27/51] target/nios2: Implement cpuid, Richard Henderson, 2022/03/17