[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH for-7.1 v6 34/51] target/nios2: Enable unaligned traps for sy
From: |
Peter Maydell |
Subject: |
Re: [PATCH for-7.1 v6 34/51] target/nios2: Enable unaligned traps for system mode |
Date: |
Thu, 17 Mar 2022 16:06:32 +0000 |
On Thu, 17 Mar 2022 at 05:35, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Unaligned traps are optional, but required with an mmu.
> Turn them on always, because the fallback behaviour is not
> documented (though presumably it discards low bits).
Mmm; the instruction descriptions just say "the operation
is undefined", so I guess we can do whatever we like :-)
> Enable alignment checks in the config file.
> Unwind the guest pc properly from do_unaligned_access.
>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/nios2/helper.c | 4 ++--
> configs/targets/nios2-softmmu.mak | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
- [PATCH for-7.1 v6 37/51] target/nios2: Use gen_goto_tb for DISAS_TOO_MANY, (continued)
- [PATCH for-7.1 v6 37/51] target/nios2: Use gen_goto_tb for DISAS_TOO_MANY, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 26/51] target/nios2: Prevent writes to read-only or reserved control fields, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 33/51] target/nios2: Drop CR_STATUS_EH from tb->flags, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 28/51] target/nios2: Implement CR_STATUS.RSIE, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 30/51] target/nios2: Support division error exception, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 34/51] target/nios2: Enable unaligned traps for system mode, Richard Henderson, 2022/03/17
- Re: [PATCH for-7.1 v6 34/51] target/nios2: Enable unaligned traps for system mode,
Peter Maydell <=
- [PATCH for-7.1 v6 35/51] target/nios2: Create gen_jumpr, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 36/51] target/nios2: Hoist set of is_jmp into gen_goto_tb, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 39/51] target/nios2: Implement Misaligned destination exception, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 38/51] target/nios2: Use tcg_gen_lookup_and_goto_ptr, Richard Henderson, 2022/03/17
- [PATCH for-7.1 v6 40/51] linux-user/nios2: Handle various SIGILL exceptions, Richard Henderson, 2022/03/17