[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v8 10/46] hw/cxl/device: Add log commands (8.2.9.4) + CEL
From: |
Jonathan Cameron |
Subject: |
[PATCH v8 10/46] hw/cxl/device: Add log commands (8.2.9.4) + CEL |
Date: |
Fri, 18 Mar 2022 15:05:59 +0000 |
From: Ben Widawsky <ben.widawsky@intel.com>
CXL specification provides for the ability to obtain logs from the
device. Logs are either spec defined, like the "Command Effects Log"
(CEL), or vendor specific. UUIDs are defined for all log types.
The CEL is a mechanism to provide information to the host about which
commands are supported. It is useful both to determine which spec'd
optional commands are supported, as well as provide a list of vendor
specified commands that might be used. The CEL is already created as
part of mailbox initialization, but here it is now exported to hosts
that use these log commands.
Signed-off-by: Ben Widawsky <ben.widawsky@intel.com>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/cxl/cxl-mailbox-utils.c | 69 ++++++++++++++++++++++++++++++++++++++
1 file changed, 69 insertions(+)
diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c
index 05e6bbdd6f..4e9cb2bccd 100644
--- a/hw/cxl/cxl-mailbox-utils.c
+++ b/hw/cxl/cxl-mailbox-utils.c
@@ -47,6 +47,9 @@ enum {
TIMESTAMP = 0x03,
#define GET 0x0
#define SET 0x1
+ LOGS = 0x04,
+ #define GET_SUPPORTED 0x0
+ #define GET_LOG 0x1
};
/* 8.2.8.4.5.1 Command Return Codes */
@@ -147,6 +150,70 @@ static ret_code cmd_timestamp_set(struct cxl_cmd *cmd,
static QemuUUID cel_uuid;
+/* 8.2.9.4.1 */
+static ret_code cmd_logs_get_supported(struct cxl_cmd *cmd,
+ CXLDeviceState *cxl_dstate,
+ uint16_t *len)
+{
+ struct {
+ uint16_t entries;
+ uint8_t rsvd[6];
+ struct {
+ QemuUUID uuid;
+ uint32_t size;
+ } log_entries[1];
+ } QEMU_PACKED *supported_logs = (void *)cmd->payload;
+ QEMU_BUILD_BUG_ON(sizeof(*supported_logs) != 0x1c);
+
+ supported_logs->entries = 1;
+ supported_logs->log_entries[0].uuid = cel_uuid;
+ supported_logs->log_entries[0].size = 4 * cxl_dstate->cel_size;
+
+ *len = sizeof(*supported_logs);
+ return CXL_MBOX_SUCCESS;
+}
+
+/* 8.2.9.4.2 */
+static ret_code cmd_logs_get_log(struct cxl_cmd *cmd,
+ CXLDeviceState *cxl_dstate,
+ uint16_t *len)
+{
+ struct {
+ QemuUUID uuid;
+ uint32_t offset;
+ uint32_t length;
+ } QEMU_PACKED QEMU_ALIGNED(16) *get_log = (void *)cmd->payload;
+
+ /*
+ * 8.2.9.4.2
+ * The device shall return Invalid Parameter if the Offset or Length
+ * fields attempt to access beyond the size of the log as reported by Get
+ * Supported Logs.
+ *
+ * XXX: Spec is wrong, "Invalid Parameter" isn't a thing.
+ * XXX: Spec doesn't address incorrect UUID incorrectness.
+ *
+ * The CEL buffer is large enough to fit all commands in the emulation, so
+ * the only possible failure would be if the mailbox itself isn't big
+ * enough.
+ */
+ if (get_log->offset + get_log->length > cxl_dstate->payload_size) {
+ return CXL_MBOX_INVALID_INPUT;
+ }
+
+ if (!qemu_uuid_is_equal(&get_log->uuid, &cel_uuid)) {
+ return CXL_MBOX_UNSUPPORTED;
+ }
+
+ /* Store off everything to local variables so we can wipe out the payload
*/
+ *len = get_log->length;
+
+ memmove(cmd->payload, cxl_dstate->cel_log + get_log->offset,
+ get_log->length);
+
+ return CXL_MBOX_SUCCESS;
+}
+
#define IMMEDIATE_CONFIG_CHANGE (1 << 1)
#define IMMEDIATE_POLICY_CHANGE (1 << 3)
#define IMMEDIATE_LOG_CHANGE (1 << 4)
@@ -162,6 +229,8 @@ static struct cxl_cmd cxl_cmd_set[256][256] = {
cmd_events_set_interrupt_policy, 4, IMMEDIATE_CONFIG_CHANGE },
[TIMESTAMP][GET] = { "TIMESTAMP_GET", cmd_timestamp_get, 0, 0 },
[TIMESTAMP][SET] = { "TIMESTAMP_SET", cmd_timestamp_set, 8,
IMMEDIATE_POLICY_CHANGE },
+ [LOGS][GET_SUPPORTED] = { "LOGS_GET_SUPPORTED", cmd_logs_get_supported, 0,
0 },
+ [LOGS][GET_LOG] = { "LOGS_GET_LOG", cmd_logs_get_log, 0x18, 0 },
};
void cxl_process_mailbox(CXLDeviceState *cxl_dstate)
--
2.32.0
- [PATCH v8 00/46] CXl 2.0 emulation Support, Jonathan Cameron, 2022/03/18
- [PATCH v8 01/46] hw/pci/cxl: Add a CXL component type (interface), Jonathan Cameron, 2022/03/18
- [PATCH v8 02/46] hw/cxl/component: Introduce CXL components (8.1.x, 8.2.5), Jonathan Cameron, 2022/03/18
- [PATCH v8 03/46] MAINTAINERS: Add entry for Compute Express Link Emulation, Jonathan Cameron, 2022/03/18
- [PATCH v8 04/46] hw/cxl/device: Introduce a CXL device (8.2.8), Jonathan Cameron, 2022/03/18
- [PATCH v8 05/46] hw/cxl/device: Implement the CAP array (8.2.8.1-2), Jonathan Cameron, 2022/03/18
- [PATCH v8 06/46] hw/cxl/device: Implement basic mailbox (8.2.8.4), Jonathan Cameron, 2022/03/18
- [PATCH v8 07/46] hw/cxl/device: Add memory device utilities, Jonathan Cameron, 2022/03/18
- [PATCH v8 08/46] hw/cxl/device: Add cheap EVENTS implementation (8.2.9.1), Jonathan Cameron, 2022/03/18
- [PATCH v8 09/46] hw/cxl/device: Timestamp implementation (8.2.9.3), Jonathan Cameron, 2022/03/18
- [PATCH v8 10/46] hw/cxl/device: Add log commands (8.2.9.4) + CEL,
Jonathan Cameron <=
- [PATCH v8 11/46] hw/pxb: Use a type for realizing expanders, Jonathan Cameron, 2022/03/18
- [PATCH v8 12/46] hw/pci/cxl: Create a CXL bus type, Jonathan Cameron, 2022/03/18
- [PATCH v8 13/46] cxl: Machine level control on whether CXL support is enabled, Jonathan Cameron, 2022/03/18
- [PATCH v8 14/46] hw/pxb: Allow creation of a CXL PXB (host bridge), Jonathan Cameron, 2022/03/18
- [PATCH v8 15/46] qtest/cxl: Introduce initial test for pxb-cxl only., Jonathan Cameron, 2022/03/18
- [PATCH v8 16/46] hw/cxl/rp: Add a root port, Jonathan Cameron, 2022/03/18
- [PATCH v8 17/46] hw/cxl/device: Add a memory device (8.2.8.5), Jonathan Cameron, 2022/03/18
- [PATCH v8 18/46] hw/cxl/device: Implement MMIO HDM decoding (8.2.5.12), Jonathan Cameron, 2022/03/18