qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] sh4: Replace TAB indentations with spaces


From: Thomas Huth
Subject: Re: [PATCH] sh4: Replace TAB indentations with spaces
Date: Fri, 18 Mar 2022 18:25:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 20/06/2021 19.54, Ahmed Abouzied wrote:
Replaces TABs with spaces, making sure to have a consistent coding style
of 4 space indentations in the SH4 subsystem.

Signed-off-by: Ahmed Abouzied <email@aabouzied.com>
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/376
---
...
@@ -1705,101 +1705,101 @@ static void _decode_opc(DisasContext * ctx)
          }
          return;
      case 0xf00d: /* fsts FPUL,FRn - FPSCR: Nothing */
-       CHECK_FPU_ENABLED
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(FREG(B11_8), cpu_fpul);
-       return;
+    return;
      case 0xf01d: /* flds FRm,FPUL - FPSCR: Nothing */
-       CHECK_FPU_ENABLED
+    CHECK_FPU_ENABLED
          tcg_gen_mov_i32(cpu_fpul, FREG(B11_8));
-       return;
+    return;

Sorry, it's a very late reply ... but in case you're still interested in fixing this: It seems like at least some of these files used TABs as 8 spaces, not as 4 spaces, so after applying your patch, the indentation seems to be wrong in all places. Please double-check the look of the files before sending! Thanks!

 Thomas




reply via email to

[Prev in Thread] Current Thread [Next in Thread]