[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL for-7.1 30/36] util/log: Rename qemu_logfile to global_file
From: |
Richard Henderson |
Subject: |
[PULL for-7.1 30/36] util/log: Rename qemu_logfile to global_file |
Date: |
Sun, 20 Mar 2022 10:11:29 -0700 |
Rename to emphasize this is the file-scope global variable.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
util/log.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/util/log.c b/util/log.c
index e559d37369..0676ce5bd6 100644
--- a/util/log.c
+++ b/util/log.c
@@ -36,7 +36,7 @@ typedef struct QemuLogFile {
static char *global_filename;
static QemuMutex qemu_logfile_mutex;
-static QemuLogFile *qemu_logfile;
+static QemuLogFile *global_file;
int qemu_loglevel;
static int log_append = 0;
static GArray *debug_regions;
@@ -44,7 +44,7 @@ static GArray *debug_regions;
/* Returns true if qemu_log() will really write somewhere. */
bool qemu_log_enabled(void)
{
- return qemu_logfile != NULL;
+ return global_file != NULL;
}
/* Returns true if qemu_log() will write somewhere other than stderr. */
@@ -54,7 +54,7 @@ bool qemu_log_separate(void)
bool res = false;
rcu_read_lock();
- logfile = qatomic_rcu_read(&qemu_logfile);
+ logfile = qatomic_rcu_read(&global_file);
if (logfile && logfile->fd != stderr) {
res = true;
}
@@ -69,7 +69,7 @@ FILE *qemu_log_lock(void)
QemuLogFile *logfile;
rcu_read_lock();
- logfile = qatomic_rcu_read(&qemu_logfile);
+ logfile = qatomic_rcu_read(&global_file);
if (logfile) {
qemu_flockfile(logfile->fd);
return logfile->fd;
@@ -133,7 +133,7 @@ static void qemu_set_log_internal(const char *filename,
bool changed_name,
QemuLogFile *logfile;
QEMU_LOCK_GUARD(&qemu_logfile_mutex);
- logfile = qemu_logfile;
+ logfile = global_file;
if (changed_name) {
char *newname = NULL;
@@ -165,7 +165,7 @@ static void qemu_set_log_internal(const char *filename,
bool changed_name,
filename = newname;
if (logfile) {
- qatomic_rcu_set(&qemu_logfile, NULL);
+ qatomic_rcu_set(&global_file, NULL);
call_rcu(logfile, qemu_logfile_free, rcu);
logfile = NULL;
}
@@ -188,7 +188,7 @@ static void qemu_set_log_internal(const char *filename,
bool changed_name,
need_to_open_file = log_flags && (!is_daemonized() || filename);
if (logfile && !need_to_open_file) {
- qatomic_rcu_set(&qemu_logfile, NULL);
+ qatomic_rcu_set(&global_file, NULL);
call_rcu(logfile, qemu_logfile_free, rcu);
return;
}
@@ -219,7 +219,7 @@ static void qemu_set_log_internal(const char *filename,
bool changed_name,
logfile = g_new0(QemuLogFile, 1);
logfile->fd = fd;
- qatomic_rcu_set(&qemu_logfile, logfile);
+ qatomic_rcu_set(&global_file, logfile);
}
}
--
2.25.1
- [PULL for-7.1 20/36] tests/unit: Do not reference QemuLogFile directly, (continued)
- [PULL for-7.1 20/36] tests/unit: Do not reference QemuLogFile directly, Richard Henderson, 2022/03/20
- [PULL for-7.1 03/36] util/log: Pass Error pointer to qemu_set_log, Richard Henderson, 2022/03/20
- [PULL for-7.1 05/36] util/log: Move qemu_log_lock, qemu_log_unlock out of line, Richard Henderson, 2022/03/20
- [PULL for-7.1 06/36] util/log: Treat qemu_log_lock like trylock, Richard Henderson, 2022/03/20
- [PULL for-7.1 29/36] util/log: Rename logfilename to global_filename, Richard Henderson, 2022/03/20
- [PULL for-7.1 30/36] util/log: Rename qemu_logfile to global_file,
Richard Henderson <=
- [PULL for-7.1 09/36] util/log: Remove qemu_log_vprintf, Richard Henderson, 2022/03/20
- [PULL for-7.1 10/36] tcg: Pass the locked filepointer to tcg_dump_ops, Richard Henderson, 2022/03/20
- [PULL for-7.1 13/36] accel/tcg: Use cpu_dump_state between qemu_log_lock/unlock, Richard Henderson, 2022/03/20
- [PULL for-7.1 12/36] exec/log: Remove log_disas and log_target_disas, Richard Henderson, 2022/03/20
- [PULL for-7.1 15/36] util/log: Use qemu_log_lock/unlock in qemu_log, Richard Henderson, 2022/03/20
- [PULL for-7.1 18/36] bsd-user: Expand log_page_dump inline, Richard Henderson, 2022/03/20