[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/15] iotests: Don't check qemu_io() output for specific err
From: |
Eric Blake |
Subject: |
Re: [PATCH 03/15] iotests: Don't check qemu_io() output for specific error strings |
Date: |
Mon, 21 Mar 2022 08:48:41 -0500 |
User-agent: |
NeoMutt/20211029-454-6adf99 |
On Fri, Mar 18, 2022 at 04:36:43PM -0400, John Snow wrote:
> A forthcoming commit updates qemu_io() to raise an exception on non-zero
> return by default, and changes its return type.
>
> In preparation, simplify some calls to qemu_io() that assert that
> specific error message strings do not appear in qemu-io's
> output. Asserting that all of these calls return a status code of zero
> will be a more robust way to guard against failure.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
> tests/qemu-iotests/040 | 33 ++++++++++++++++-----------------
> tests/qemu-iotests/056 | 2 +-
> 2 files changed, 17 insertions(+), 18 deletions(-)
>
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org