Re: [PATCH v4 0/6] Introduce CanoKey QEMU

[Gerd Hoffmann]

  Hi,

> > I'd suggest to run the patch series through the qemu gitlab CI
> > before sending out v5.
> 
> I have gone through qemu gitlab CI and the result is in
> https://gitlab.com/ZenithalHourlyRate/qemu/-/pipelines/497317417
> Except check-dco and check-patch (I only generate Signed-off-by line
> when `git format-patch`), other failed checks are "allowed to fail" and
> I've checked the log, these failures are about Debian RISC-V packages
> instead of qemu itself.

Sounds fine.  The risc-v bits seem to be in progress still, I have
failures with them too.

> Is this appropriate for sending out v5?
> 
> By the way, we are planning to separate libcanokey-qemu.so
> from canokey-core to a dedicated repo at
> https://github.com/canokeys/canokey-qemu
> (not done yet), which would result in changes in documentation.
> I will contain these changes in v5 once we are done.

If you want split the library it makes sense to do that (and test in CI)
before sending out v5.

No need to hurry right now, qemu is in freeze for the 7.0 release so it
can be merged only after the tree re-opens for 7.1 development (roughly
one month from now).

take care,
  Gerd