Re: [PATCH v3 5/5] i386/cpu: Free env->xsave_buf in KVM and HVF destory_vcpu_thread routines

[Philippe Mathieu-Daudé]

On 21/3/22 23:08, Philippe Mathieu-Daudé wrote:
> On 21/3/22 23:04, Philippe Mathieu-Daudé wrote:
> > On 21/3/22 15:14, Mark Kanda wrote:
> > > Create KVM and HVF specific destory_vcpu_thread() routines to free
> >
> > Typo "destroy"
> >
> > > env->xsave_buf.
> > >
> > > vCPU hotunplug related leak reported by Valgrind:
> > >
> > > ==132362== 4,096 bytes in 1 blocks are definitely lost in loss record 
> > > 8,440 of 8,549
> > > ==132362==    at 0x4C3B15F: memalign (vg_replace_malloc.c:1265)
> > > ==132362==    by 0x4C3B288: posix_memalign (vg_replace_malloc.c:1429)
> > > ==132362==    by 0xB41195: qemu_try_memalign (memalign.c:53)
> > > ==132362==    by 0xB41204: qemu_memalign (memalign.c:73)
> > > ==132362==    by 0x7131CB: kvm_init_xsave (kvm.c:1601)
> > > ==132362==    by 0x7148ED: kvm_arch_init_vcpu (kvm.c:2031)
> > > ==132362==    by 0x91D224: kvm_init_vcpu (kvm-all.c:516)
> > > ==132362==    by 0x9242C9: kvm_vcpu_thread_fn (kvm-accel-ops.c:40)
> > > ==132362==    by 0xB2EB26: qemu_thread_start (qemu-thread-posix.c:556)
> > > ==132362==    by 0x7EB2159: start_thread (in 
> > > /usr/lib64/libpthread-2.28.so)
> > > ==132362==    by 0x9D45DD2: clone (in /usr/lib64/libc-2.28.so)
> > >
> > > Signed-off-by: Mark Kanda <mark.kanda@oracle.com>
> > > ---
> > >   accel/hvf/hvf-accel-ops.c | 11 ++++++++++-
> > >   accel/kvm/kvm-accel-ops.c | 11 ++++++++++-
> > >   2 files changed, 20 insertions(+), 2 deletions(-)
> >
> > Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>
> I meant:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Withdrawing these tags with HVF.

First xsave_buf is only allocated by KVM, second accel/ directory is
meant to be target agnostic, so x86-specific code there is not right.