Re: [PATCH 01/15] iotests: replace calls to log(qemu_io(...)) with qemu_io_log()

[Hanna Reitz]

On 18.03.22 21:36, John Snow wrote:
> This makes these callsites a little simpler, but the real motivation is
> a forthcoming commit will change the return type of qemu_io(), so removing
> users of the return value now is helpful.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
> ---
>   tests/qemu-iotests/242 | 2 +-
>   tests/qemu-iotests/255 | 4 +---
>   tests/qemu-iotests/303 | 4 ++--
>   3 files changed, 4 insertions(+), 6 deletions(-)

Perfectly reasonable, but...

> diff --git a/tests/qemu-iotests/242 b/tests/qemu-iotests/242
> index b3afd36d72..4b7ec16af6 100755
> --- a/tests/qemu-iotests/242
> +++ b/tests/qemu-iotests/242
> @@ -61,7 +61,7 @@ def add_bitmap(bitmap_number, persistent, disabled):
>   
>   def write_to_disk(offset, size):
>       write = 'write {} {}'.format(offset, size)
> -    log(qemu_io('-c', write, disk), filters=[filter_qemu_io])
> +    qemu_io_log('-c', write, disk)

This breaks 242 because qemu_io_log is not imported.

Hanna