qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] github: fix config mistake preventing repo lockdown commenting


From: Daniel P . Berrangé
Subject: [PATCH] github: fix config mistake preventing repo lockdown commenting
Date: Wed, 23 Mar 2022 11:45:16 +0000

The config key names were all wrong, resulting in the repo lockdown
throwing warnings:

  Unexpected input(s) 'pull-comment', 'lock-pull', 'close-pull',
  valid inputs are ['github-token', 'exclude-issue-created-before',
  'exclude-issue-labels', 'issue-labels', 'issue-comment',
  'skip-closed-issue-comment', 'close-issue', 'lock-issue',
  'issue-lock-reason', 'exclude-pr-created-before', 'exclude-pr-labels',
  'pr-labels', 'pr-comment', 'skip-closed-pr-comment', 'close-pr',
  'lock-pr', 'pr-lock-reason', 'process-only', 'log-output']

It still locked down the pull requests, due to its default config,
but didn't leave the friendly message explaining why.

Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
---
 .github/workflows/lockdown.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/.github/workflows/lockdown.yml b/.github/workflows/lockdown.yml
index ad8b8f7e30..d5e1265cff 100644
--- a/.github/workflows/lockdown.yml
+++ b/.github/workflows/lockdown.yml
@@ -15,7 +15,7 @@ jobs:
     steps:
       - uses: dessant/repo-lockdown@v2
         with:
-          pull-comment: |
+          pr-comment: |
             Thank you for your interest in the QEMU project.
 
             This repository is a read-only mirror of the project's repostories 
hosted
@@ -26,5 +26,5 @@ jobs:
             functionality). However, we get a lot of patches, and so we have 
some
             guidelines about contributing on the project website:
             https://www.qemu.org/contribute/
-          lock-pull: true
-          close-pull: true
+          lock-pr: true
+          close-pr: true
-- 
2.34.1




reply via email to

[Prev in Thread] Current Thread [Next in Thread]