Re: Re: [RESEND 1/2] qga: Introduce NVMe disk bus type

[zhenwei pi]

On 3/23/22 18:53, Philippe Mathieu-Daudé wrote:
> On 23/3/22 11:19, zhenwei pi wrote:
> > Assigning a NVMe disk by VFIO or emulating a NVMe controller by QEMU,
> > a NVMe disk get exposed in guest side. Support NVMe disk bus type and
> > implement posix version.
> >
> > Test PCI passthrough case:
> > ~#virsh qemu-agent-command buster '{"execute":"guest-get-disks"}' | jq
> >    ...
> >      {
> >        "name": "/dev/nvme0n1",
> >        "dependencies": [],
> >        "partition": false,
> >        "address": {
> >          "serial": "SAMSUNG MZQL23T8HCLS-00A07_S64HNE0N500076",
> >          "bus-type": "nvme",
> >          "bus": 0,
> >          "unit": 0,
> >          "pci-controller": {
> >            "bus": 0,
> >            "slot": 22,
> >            "domain": 0,
> >            "function": 0
> >          },
> >          "dev": "/dev/nvme0n1",
> >          "target": 0
> >        }
> >    ...
> >
> > Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> > ---
> >   qga/commands-posix.c | 5 ++++-
> >   qga/qapi-schema.json | 3 ++-
> >   2 files changed, 6 insertions(+), 2 deletions(-)
>
> > diff --git a/qga/qapi-schema.json b/qga/qapi-schema.json
> > index 94e4aacdcc..4ea2a50228 100644
> > --- a/qga/qapi-schema.json
> > +++ b/qga/qapi-schema.json
> > @@ -827,13 +827,14 @@
> >   # @mmc: Win multimedia card (MMC) bus type
> >   # @virtual: Win virtual bus type
> >   # @file-backed-virtual: Win file-backed bus type
> > +# @nvme: NVMe disks (since 7.0)
>
> If this patch isn't merged soon, this will need to be updated.
>
> BTW I think I already review this patch, anyhow:
> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Thanks a lot! I'll update the version info if this patch is deferred.

--
zhenwei pi