[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 2/6] crypto-akcipher: Introduce akcipher types to qapi
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v3 2/6] crypto-akcipher: Introduce akcipher types to qapi |
Date: |
Wed, 23 Mar 2022 15:00:54 +0000 |
User-agent: |
Mutt/2.1.5 (2021-12-30) |
On Wed, Mar 23, 2022 at 10:49:08AM +0800, zhenwei pi wrote:
> From: Lei He <helei.sig11@bytedance.com>
>
> Introduce akcipher types, also include RSA & ECDSA related types.
>
> Signed-off-by: Lei He <helei.sig11@bytedance.com>
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
> ---
> qapi/crypto.json | 86 ++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 86 insertions(+)
>
> diff --git a/qapi/crypto.json b/qapi/crypto.json
> index 1ec54c15ca..d44c38e3b1 100644
> --- a/qapi/crypto.json
> +++ b/qapi/crypto.json
> @@ -540,3 +540,89 @@
> 'data': { '*loaded': { 'type': 'bool', 'features': ['deprecated'] },
> '*sanity-check': 'bool',
> '*passwordid': 'str' } }
> +##
> +# @QCryptoAkcipherAlgorithm:
> +#
> +# The supported algorithms for asymmetric encryption ciphers
> +#
> +# @rsa: RSA algorithm
> +# @ecdsa: ECDSA algorithm
> +#
> +# Since: 7.0
> +##
> +{ 'enum': 'QCryptoAkcipherAlgorithm',
> + 'prefix': 'QCRYPTO_AKCIPHER_ALG',
> + 'data': ['rsa', 'ecdsa']}
What were your intentions wrt ecdsa - the nettle impl in this patch
series doesn't appear to actually support ecdsa. Are you intending to
add this in later versions of this patch series, or do it as separate
work at a later date ?
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v3 0/6] Support akcipher for virtio-crypto, zhenwei pi, 2022/03/22
- [PATCH v3 1/6] virtio-crypto: header update, zhenwei pi, 2022/03/22
- [PATCH v3 2/6] crypto-akcipher: Introduce akcipher types to qapi, zhenwei pi, 2022/03/22
- [PATCH v3 3/6] crypto: Introduce akcipher crypto class, zhenwei pi, 2022/03/22
- [PATCH v3 4/6] crypto: Implement RSA algorithm by hogweed, zhenwei pi, 2022/03/22
- [PATCH v3 5/6] tests/crypto: Add test suite for crypto akcipher, zhenwei pi, 2022/03/22
- [PATCH v3 6/6] virtio-crypto: Introduce RSA algorithm, zhenwei pi, 2022/03/22
- Re: [PATCH v3 0/6] Support akcipher for virtio-crypto, Eric Biggers, 2022/03/23