qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 for-7.1] vfio/common: remove spurious tpm-crb-cmd misalign


From: Stefan Berger
Subject: Re: [PATCH v3 for-7.1] vfio/common: remove spurious tpm-crb-cmd misalignment warning
Date: Thu, 24 Mar 2022 08:40:50 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.2



On 3/24/22 07:50, Cornelia Huck wrote:
On Wed, Mar 23 2022, Eric Auger <eric.auger@redhat.com> wrote:

The CRB command buffer currently is a RAM MemoryRegion and given
its base address alignment, it causes an error report on
vfio_listener_region_add(). This region could have been a RAM device
region, easing the detection of such safe situation but this option
was not well received. So let's add a helper function that uses the
memory region owner type to detect the situation is safe wrt
the assignment. Other device types can be checked here if such kind
of problem occurs again.

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

---

v2 -> v3:
- Use TPM_IS_CRB()

v1 -> v2:
- do not check the MR name but rather the owner type
---
  hw/vfio/common.c     | 27 ++++++++++++++++++++++++++-
  hw/vfio/trace-events |  1 +
  2 files changed, 27 insertions(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@redhat.com>

Acked-by: Stefan Berger <stefanb@linux.ibm.com>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]