Re: [PATCH 11/14] qapi: fix example of MEMORY_FAILURE

[John Snow]

On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote:
>
> Minor issues found and fixed with the example:
> * The JSON object of EVENT was not closed
> * Missing timestamp
> * Flags are optional but if defined then all members should be
>   include so we add "recursive" member.

Oh, yeah. Good call.

> * Changed string from '' to "" in action-required member.
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
>  qapi/run-state.json | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/qapi/run-state.json b/qapi/run-state.json
> index f87b9378ac..ee21decdec 100644
> --- a/qapi/run-state.json
> +++ b/qapi/run-state.json
> @@ -571,7 +571,9 @@
>  # <- { "event": "MEMORY_FAILURE",
>  #      "data": { "recipient": "hypervisor",
>  #                "action": "fatal",
> -#                "flags": { 'action-required': false } }
> +#                "flags": { "action-required": false,
> +#                           "recursive": false } },
> +#      "timestamp": { "seconds": 1267061043, "microseconds": 959568 } }
>  #
>  ##
>  { 'event': 'MEMORY_FAILURE',
> --
> 2.35.1
>

Reviewed-by: John Snow <jsnow@redhat.com>