[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 14/14] qapi: fix example of dump-guest-memory
From: |
John Snow |
Subject: |
Re: [PATCH 14/14] qapi: fix example of dump-guest-memory |
Date: |
Thu, 24 Mar 2022 17:31:59 -0400 |
On Thu, Mar 24, 2022 at 1:50 PM Victor Toso <victortoso@redhat.com> wrote:
>
> The member "paging" is not optional
>
> Signed-off-by: Victor Toso <victortoso@redhat.com>
> ---
> qapi/dump.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/qapi/dump.json b/qapi/dump.json
> index d3ed79e8cd..0873f16e5c 100644
> --- a/qapi/dump.json
> +++ b/qapi/dump.json
> @@ -83,7 +83,7 @@
> # Example:
> #
> # -> { "execute": "dump-guest-memory",
> -# "arguments": { "protocol": "fd:dump" } }
> +# "arguments": { "paging": false, "protocol": "fd:dump" } }
> # <- { "return": {} }
> #
> ##
> --
> 2.35.1
>
Assuming this is a feasible example.
Reviewed-by: John Snow <jsnow@redhat.com>
- Re: [PATCH 06/14] qapi: fix example of MEMORY_DEVICE_SIZE_CHANGE event, (continued)
- [PATCH 08/14] qapi: fix example of FAILOVER_NEGOTIATED event, Victor Toso, 2022/03/24
- [PATCH 14/14] qapi: fix example of dump-guest-memory, Victor Toso, 2022/03/24
- Re: [PATCH 14/14] qapi: fix example of dump-guest-memory,
John Snow <=
- [PATCH 12/14] qapi: ui examples: add missing websocket member, Victor Toso, 2022/03/24
- [PATCH 02/14] qapi: fix example of BLOCK_IMAGE_CORRUPTED event, Victor Toso, 2022/03/24
Re: [PATCH 00/14] Fix some qapi examples and a TODO section, John Snow, 2022/03/24