[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 1/5] vfio: simplify the conditional statements in vfio_msi_ena
From: |
Longpeng(Mike) |
Subject: |
[PATCH v6 1/5] vfio: simplify the conditional statements in vfio_msi_enable |
Date: |
Sat, 26 Mar 2022 14:02:22 +0800 |
It's unnecessary to test against the specific return value of
VFIO_DEVICE_SET_IRQS, since any positive return is an error
indicating the number of vectors we should retry with.
Signed-off-by: Longpeng(Mike) <longpeng2@huawei.com>
---
hw/vfio/pci.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c
index d07a4e99b1..1433989aeb 100644
--- a/hw/vfio/pci.c
+++ b/hw/vfio/pci.c
@@ -653,7 +653,7 @@ retry:
if (ret) {
if (ret < 0) {
error_report("vfio: Error: Failed to setup MSI fds: %m");
- } else if (ret != vdev->nr_vectors) {
+ } else {
error_report("vfio: Error: Failed to enable %d "
"MSI vectors, retry with %d", vdev->nr_vectors, ret);
}
@@ -671,7 +671,7 @@ retry:
g_free(vdev->msi_vectors);
vdev->msi_vectors = NULL;
- if (ret > 0 && ret != vdev->nr_vectors) {
+ if (ret > 0) {
vdev->nr_vectors = ret;
goto retry;
}
--
2.23.0
- [PATCH v6 0/5] optimize the downtime for vfio migration, Longpeng(Mike), 2022/03/26
- [PATCH v6 5/5] vfio: defer to commit kvm irq routing when enable msi/msix, Longpeng(Mike), 2022/03/26
- [PATCH v6 1/5] vfio: simplify the conditional statements in vfio_msi_enable,
Longpeng(Mike) <=
- [PATCH v6 3/5] vfio: simplify the failure path in vfio_msi_enable, Longpeng(Mike), 2022/03/26
- [PATCH v6 2/5] vfio: move re-enabling INTX out of the common helper, Longpeng(Mike), 2022/03/26
- [PATCH v6 4/5] Revert "vfio: Avoid disabling and enabling vectors repeatedly in VFIO migration", Longpeng(Mike), 2022/03/26
- Re: [PATCH v6 0/5] optimize the downtime for vfio migration, Alex Williamson, 2022/03/28